[#504] ProfileView 탭 모드를 content, detail로 수정한다#509
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 프로필 탭의 일반(Regular) 레이아웃 지원을 추가하고, 화면 크기(isCompactLayout)에 따라 내비게이션 동작을 다르게 처리하도록 MainView와 ProfileView를 리팩토링합니다. 이에 대해 리뷰어는 profileRegularDetailView 전체를 하나의 NavigationStack으로 감싸 뷰의 구조적 ID를 유지하고 애니메이션을 개선할 것과, profileDestinationView의 .activity 케이스에서 SwiftUI 뷰 상태 재사용 문제를 방지하기 위해 .id(todoId)를 추가할 것을 제안했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
contentDetail구조로 정리TodoDetailView노출 방식 적용SettingView노출 방식 적용navigationSplitViewColumnWidth(min: 350, ideal: 450, max: nil)적용mainTabSplitStyle관련 분기 제거🔍 상세
MainViewsidebarView(for:)를selectedTab직접 분기 구조로 정리ProfileRoute의 현재 root에 따라TodoDetailView또는 설정 관련 화면을 표시하도록 구성content컬럼에 동일한 split view width 정책 적용ProfileViewpush(.settings)유지replace(with: .settings)로 detail 패널 교체 방식 적용Localizable.xcstringsprofile_select_detail추가활동을 선택해주세요.문구로 분리📸 영상 / 이미지 (Optional)